Skip to content

Conversation

@remicollet
Copy link
Member

@remicollet remicollet requested a review from nikic October 12, 2021 07:44
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG assuming it doesn't break CI.

@remicollet
Copy link
Member Author

No... won't work.... with like php81-php

@remicollet
Copy link
Member Author

remicollet commented Oct 12, 2021

@nikic seems better.... but probably some cases are still not handled... at least the common ones are ok

e.g.

  • no prefix / suffix
  • "zts-" prefix
  • "php81-" prefix with php
  • "81" suffix

(such cases, like "myphp" suffix, still broken... )

@remicollet remicollet requested a review from nikic October 12, 2021 08:24
@nikic
Copy link
Member

nikic commented Oct 12, 2021

I liked the previous version more. Supporting php81-php imho doesn't make sense, as we can't make a sensible guess if the string contains php more than once. Correct spelling is php-8.1 or php8.1.

@remicollet
Copy link
Member Author

1st way merged as ea00e65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants