Fix #72809: Locale::lookup() wrong result with canonicalize option #7151
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canonicalization converts the locale to ICU format[1]. However, the lookup described in RFC 4647, section 3.4, is about POSIX format. To make that lookup work for ICU format, we also need to cater to keyword separators. The results are somewhat unexpected, but apparently canonical lookup is explicitly supposed to return canonical language tags[2]. [1] <https://unicode-org.github.io/icu/userguide/locale/#canonicalization> [2] <https://github.com/php/php-src/blob/php-7.4.20/ext/intl/locale/locale_methods.c#L1504>
nikic
approved these changes
Jun 15, 2021
Member
nikic
left a comment
There was a problem hiding this comment.
Not really familiar with the area, but looks reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonicalization converts the locale to ICU format[1]. However, the
lookup described in RFC 4647, section 3.4, is about POSIX format. To
make that lookup work for ICU format, we also need to cater to keyword
separators.
The results are somewhat unexpected, but apparently canonical lookup is
explicitly supposed to return canonical language tags[2].
[1] https://unicode-org.github.io/icu/userguide/locale/#canonicalization
[2] https://github.com/php/php-src/blob/php-7.4.20/ext/intl/locale/locale_methods.c#L1504