Fix #44643: bound parameters ignore explicit type definitions #6973
+32
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `SQLDescribeParam()` fails for a parameter, we must not assume `SQL_LONGVARCHAR` for any param which is not `PDO_PARAM_LOB`. At least mapping `PDO_PARAM_INT` to `SQL_INTEGER` should be safe, and not introduce a BC break.
Member
|
Given the recent fiasco with a similar change to PDO pgsql, this seems rather risky... |
Member
Author
|
Looks quite different to me, but I'd be fine with rebasing onto master. |
nikic
approved these changes
May 11, 2021
Member
nikic
left a comment
There was a problem hiding this comment.
After taking a closer look, yes, I think this is fine. It's fallback code, the integer type is generic, and it's still nullable.
I don't know much about odbc, but on the surface this looks reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
SQLDescribeParam()fails for a parameter, we must not assumeSQL_LONGVARCHARfor any param which is notPDO_PARAM_LOB. At leastmapping
PDO_PARAM_INTtoSQL_INTEGERshould be safe, and notintroduce a BC break.