Bug #67403 Add signatureType to openssl_x509_parse #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding openssl signature parsing to openssl_x509_parse, so for instance, a cert with a sha1 signature should say sha1WithRSAEncryption (and not SHA1-With-RSA like other openssl signature functions might produce). There was some old commented out code, that didn't work. This pull request replaces it with working code.
Also removed unused const, DEFAULT_KEY_LENGTH in openssl, it was copied from req.c in the openssl examples source code, and is not otherwise used in php code. See how it was copied over from req.c (openssl source) when ext/openssl/openssl.c was first being written:
http://www.opensource.apple.com/source/OpenSSL098/OpenSSL098-32/src/apps/req.c?txt
(leaving it in is a bit misleading, because it appears to be a default key length, but actually defaults are controlled by openssl.cnf).