Skip to content

Conversation

@mk-j
Copy link
Contributor

@mk-j mk-j commented Jun 9, 2014

Adding openssl signature parsing to openssl_x509_parse, so for instance, a cert with a sha1 signature should say sha1WithRSAEncryption (and not SHA1-With-RSA like other openssl signature functions might produce). There was some old commented out code, that didn't work. This pull request replaces it with working code.

Also removed unused const, DEFAULT_KEY_LENGTH in openssl, it was copied from req.c in the openssl examples source code, and is not otherwise used in php code. See how it was copied over from req.c (openssl source) when ext/openssl/openssl.c was first being written:
http://www.opensource.apple.com/source/OpenSSL098/OpenSSL098-32/src/apps/req.c?txt
(leaving it in is a bit misleading, because it appears to be a default key length, but actually defaults are controlled by openssl.cnf).

@nikic nikic closed this Mar 5, 2015
@rdlowrey
Copy link
Contributor

rdlowrey commented Mar 5, 2015

This bug/feature request was addressed by http://git.php.net/?p=php-src.git;a=commit;h=94140afa69e334405688d3cb09a47c07aeaef825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants