Skip to content

Conversation

@twose
Copy link
Member

@twose twose commented Apr 15, 2021

The function name should be kept if Closure was created from the function which is marked as ZEND_ACC_CALL_VIA_TRAMPOLINE, because it is not a one-time thing and it may be called multiple times.

This is still the first time I read the Closure code and I also don't know if the patch is correct... but it did work for this case.

The function name should be kept if Closure was created from the function which is marked as ZEND_ACC_CALL_VIA_TRAMPOLINE, because it is not a one-time thing and it may be called multiple times.
@twose twose requested a review from nikic April 15, 2021 04:07
@twose twose changed the base branch from master to PHP-7.4 April 15, 2021 05:58
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@twose twose closed this in c0b1bdc Apr 16, 2021
@twose twose deleted the bug80929 branch April 16, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants