Skip to content

Fix #77322: PharData::addEmptyDir('/') Possible integer overflow #6508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmb69 wants to merge 1 commit into from
Closed

Fix #77322: PharData::addEmptyDir('/') Possible integer overflow #6508

cmb69 wants to merge 1 commit into from

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Dec 11, 2020

phar_path_check() already strips a leading slash, so we must not
attempt to strip the trailing slash from an now empty directory name.

@cmb69
Fix #77322: PharData::addEmptyDir('/') Possible integer overflow
8c5e638 
`phar_path_check()` already strips a leading slash, so we must not
attempt to strip the trailing slash from an now empty directory name.
@cmb69 cmb69 added the Bug label Dec 11, 2020
@php-pulls php-pulls closed this in a53d67c Dec 15, 2020
@cmb69 cmb69 deleted the cmb/77322 branch December 15, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmb69 @nikic