Skip to content

Fix #80280: ADD_EXTENSION_DEP() fails for ext/standard and ext/date #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmb69 wants to merge 1 commit into from
Closed

Fix #80280: ADD_EXTENSION_DEP() fails for ext/standard and ext/date #6383

cmb69 wants to merge 1 commit into from

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 24, 2020

ADD_EXTENSION_DEP() relies on the PHP_<extname> config variables to
be set to "yes", and since the standard and date extension are always
enabled, we define the respective variables uncoditionally.

@cmb69
Fix #80280: ADD_EXTENSION_DEP() fails for ext/standard and ext/date
34672ca 
`ADD_EXTENSION_DEP()` relies on the `PHP_<extname>` config variables to
be set to `"yes"`, and since the standard and date extension are always
enabled, we define the respective variables uncoditionally.
@cmb69 cmb69 added the Bug label Oct 24, 2020
@cmb69 cmb69 mentioned this pull request Oct 24, 2020
Closed
@kallesommernielsen
Copy link
Member

kallesommernielsen commented Oct 24, 2020

What about if we added a new function that was called something along the likes of PHP_ALWAYS_ENABLED_EXT(name) that did this behind the scenes and it is very explicit for every case that does not use the check-lib/include style functions that passes in this value

@Jan-E
Copy link
Contributor

Jan-E commented Oct 24, 2020

Beware: with this commit ADD_EXTENSION_DEP() for ext/standard and ext/date will still fail in PHP 7.2 and older.

@cmb69
Copy link
Member Author

cmb69 commented Oct 26, 2020

@kallesommernielsen, these PHP_<extname> variables are usually set by the ARG_WITH()/ARG_ENABLE() functions; extensions which are always available don't call these functions, though, and I think just setting the variable manually in this case is fine.

@Jan-E, right.

@php-pulls php-pulls closed this in 2be2707 Oct 26, 2020
@cmb69 cmb69 deleted the cmb/80280 branch October 26, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmb69 @kallesommernielsen @Jan-E @nikic