Fix #64076: imap_sort() does not return FALSE on failure #6332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If unsupported `$search_criteria` are passed to `imap_sort()`, the
function returns an empty array, but there is also an error on the
libc-client error stack ("Unknown search criterion: UNSUPPORTED
(errflg=2)"). If, on the other hand, unsupported `$criteria` or
unsupported `$flags` are passed, the function returns `false`. We
solve this inconsistency by returning `false` for unsupported
`$search_criteria` as well.
nikic
approved these changes
Oct 13, 2020
Member
nikic
left a comment
There was a problem hiding this comment.
I'm okay with this as-is, also for 7.3. If imap reports and error, we should treat it as an error...
Member
Author
|
Makes sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If unsupported
$search_criteriaare passed toimap_sort(), thefunction returns an empty array, but there is also an error on the
libc-client error stack ("Unknown search criterion: UNSUPPORTED
(errflg=2)"). If, on the other hand, unsupported
$criteriaorunsupported
$flagsare passed, the function returnsfalse. Wesolve this inconsistency by returning
falsefor unsupported$search_criteriaas well.I'm unsure about the "details" here. Silently failing is unusual, but seems to be pretty common for ext/imap. Also I'm not sure which branch to target. While I consider the behavior a bug, returning an empty array is not terribly wrong, so maybe 8.0/master would be more appropriate.