Update pdo_odbc to use SQLLEN where appropriate #629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many ODBC APIs were changed to use SQLLEN instead of SQLINTEGER. This has the benefit of allowing 64-bit parameters on 64-bit platforms, but causes problems if your application is not updated to use these 64-bit types. If you pass a pointer to the wrong size variable, you will get unpredictible results.as the driver will read or write to random memory. For more information, see http://msdn.microsoft.com/en-us/library/windows/desktop/ms716287%28v=vs.85%29.aspx This was changed in Windows Server 2003 on Windows and in unixODBC 2.2.14, which was released in November 2008. It's about time it was fixed in pdo_odbc.
|
Can one of the admins verify this patch? |
Contributor
Author
|
Looks nearly all of my changes were already added here: http://git.php.net/?p=php-src.git;a=commit;h=186ffcb72c982b0235761bdd6388ff1c36d79568. The only thing that wasn't pulled in was the change from SQLINTEGER to SQLLEN for len in the pdo_odbc_param struct. |
Contributor
Author
|
Oops, I was mistaken. That change was included, but my change for datalen to SQLLEN was not. That has been changed to zend_ulong and doesn't get passed to any ODBC API (by address or by value), so should be fine. Due to that, this pull request is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many ODBC APIs were changed to use SQLLEN instead of SQLINTEGER. This
has the benefit of allowing 64-bit parameters on 64-bit platforms, but
causes problems if your application is not updated to use these 64-bit
types. If you pass a pointer to the wrong size variable, you will get
unpredictible results.as the driver will read or write to random memory.
For more information, see
http://msdn.microsoft.com/en-us/library/windows/desktop/ms716287%28v=vs.85%29.aspx
This was changed in Windows Server 2003 on Windows and in unixODBC
2.2.14, which was released in November 2008. It's about time it was
fixed in pdo_odbc.