Skip to content

isset() and empty() don't invoke ArrayObject::offsetGet() #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datibbaw wants to merge 2 commits into from
Closed

isset() and empty() don't invoke ArrayObject::offsetGet() #614

datibbaw wants to merge 2 commits into from

Conversation

@datibbaw
Copy link
Contributor

@datibbaw datibbaw commented Mar 7, 2014

This fixed bug 66834.

Both isset() and empty() should inspect the value after checking whether the offset exists (or by calling offsetExists()).

@datibbaw datibbaw closed this Mar 8, 2014
@datibbaw datibbaw deleted the bug66834 branch March 8, 2014 09:52
@datibbaw datibbaw mentioned this pull request Mar 8, 2014
Closed
@datibbaw datibbaw restored the bug66834 branch March 20, 2014 23:15
@datibbaw datibbaw reopened this Mar 21, 2014
@datibbaw
Copy link
Contributor Author

datibbaw commented Mar 25, 2014

Merged into 5.6 and master.

@datibbaw datibbaw closed this Mar 25, 2014
@Ocramius Ocramius mentioned this pull request Apr 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@datibbaw