Skip to content

dns_check_record() always return true on Alpinelinux #78008 #5854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andypost wants to merge 1 commit into from
Closed

dns_check_record() always return true on Alpinelinux #78008 #5854

andypost wants to merge 1 commit into from

Conversation

@andypost
Copy link
Contributor

@andypost andypost commented Jul 14, 2020

Ref https://bugs.php.net/bug.php?id=78008

  • free handle before return result
  • cleaned up remaining usage of MAXPACKET
  • update dns_get_mx() to use the same type

@andypost
Copy link
Contributor Author

andypost commented Jul 14, 2020

AppVeyor failed test is unrelated

FAILED TEST SUMMARY
---------------------------------------------------------------------
Bug #79828: Segfault when trying to access non-existing variable [C:\projects\php-src\Zend\tests\bug79828.phpt]

nikic
nikic reviewed Jul 14, 2020
View reviewed changes
nikic
nikic reviewed Jul 14, 2020
View reviewed changes
@andypost
dns_check_record() always return true on Alpinelinux #78088
46ddf2f 
- free handle before return result
- cleaned up remaining usage of MAXPACKET
- update dns_get_mx() to use the same approach
@nikic nikic changed the title dns_check_record() always return true on Alpinelinux #78088 dns_check_record() always return true on Alpinelinux #78008 Jul 15, 2020
@php-pulls php-pulls closed this in 2c57378 Jul 15, 2020
@andypost andypost deleted the 78008-dns branch July 15, 2020 14:31
@ekinhbayar
Copy link
Contributor

ekinhbayar commented Aug 10, 2020

Hi o/ I've recently filed this bug report that is related to this PR. TL;DR is getmxrr seems to be still failing on our alpine based 7.4.9 pipelines. Notes from the quick discussion about this:
Nikita: Hm, looks like the function returns true for ancount==0

@andypost
Copy link
Contributor Author

andypost commented Aug 20, 2020

@ekinhbayar Confirm that, when domain is wrong it still returns TRUE

$ php8 -r '$a=[];var_dump(dns_get_mx("gmail.com.aaaa", $a));var_dump($a);'
bool(true)
array(0) {
}

@andypost
Copy link
Contributor Author

andypost commented Aug 31, 2020

that's because dns reports success but empty check is wrong

@ekinhbayar
Copy link
Contributor

ekinhbayar commented Sep 1, 2020

Hi @andypost, for your information, Nikita recently commited a change for this, though I couldn't find the chance to test it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andypost @ekinhbayar @nikic @carusogabriel