Fix #63208: BSTR to PHP string conversion not binary safe #5766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
BSTRis similar to azend_string; it stores the length of thestring just before the actual string, and thus the string may contain
NUL bytes. However,
php_com_olestring_to_string()is supposed todeal with arbitrary
OLECHAR*s which may not beBSTRs, so weintroduce
php_com_bstr_to_string()and use it for the only case wherewe actually have to deal with
BSTRs which may contain NUL bytes.Contrary to
php_com_olestring_to_string()we return azend_string,so we can save the re-allocation when converting to a
zval.