Fix #55857: ftp_size on large files #5757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`atol()` returns a `long` which is not the same as `zend_long` on LLP64; we use `ZEND_ATOL()` instead. There is no need for a new test case, since filesize_large.phpt already tests for that behavior; unfortunately, the FTP test suite relies on `pcntl_fork()` and therefore cannot be run on Windows.
nikic
approved these changes
Jun 23, 2020
| return -1; | ||
| } | ||
| return atol(ftp->inbuf); | ||
| ZEND_ATOL(res, ftp->inbuf); |
Member
There was a problem hiding this comment.
Gotta wonder, why the heck does ZEND_ATOL include a variable assignment instead of just returning the value?
Member
Author
There was a problem hiding this comment.
Looks like an unfortunate design decision, but probably too much BC break if we change that.
Member
Author
|
Thanks! Applied as e94126a |
Contributor
|
@cmb69 Sorry, I didn't see that the base branch was |
Member
Author
|
@carusogabriel, no problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atol()returns alongwhich is not the same aszend_longonLLP64; we use
ZEND_ATOL()instead.There is no need for a new test case, since filesize_large.phpt already
tests for that behavior; unfortunately, the FTP test suite relies on
pcntl_fork()and therefore cannot be run on Windows.