Skip to content

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Apr 20, 2020

On Windows, PATH_TRANSLATED may contain backslashes as well as slashes,
so we must not only check for DEFAULT_SLASH.

PS: could do this ifdef PHP_WIN32 only.

On Windows, PATH_TRANSLATED may contain backslashes as well as slashes,
so we must not only check for `DEFAULT_SLASH`.
@cmb69 cmb69 added the Bug label Apr 21, 2020
@cmb69
Copy link
Member Author

cmb69 commented May 5, 2020

I have now added the #ifdef, so this change only affects Windows.

If there are no objections, I'll merge this in a week.

@cmb69
Copy link
Member Author

cmb69 commented May 12, 2020

Applied as bdba0cd. Thanks!

@cmb69 cmb69 closed this May 12, 2020
@cmb69 cmb69 deleted the cmb/79489 branch May 12, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant