Skip to content

Fix Bug #79296 ZipArchive::open fails on empty file #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
remicollet wants to merge 1 commit into from
Closed

Fix Bug #79296 ZipArchive::open fails on empty file #5281

remicollet wants to merge 1 commit into from

Conversation

@remicollet
Copy link
Member

@remicollet remicollet commented Mar 19, 2020

Try to reduce the minor BC break introduce in libzip 1.6.0

See https://bugs.php.net/bug.php?id=79296

Above code seems quite ok...

$f = tempnam(sys_get_temp_dir(), 'xxx');
$zip = new ZipArchive();
$success = $zip->open($f);

Open for discussion, don't know if we should even try to fix this

@cmb69
Copy link
Member

cmb69 commented Mar 20, 2020

I think the reasoning behind nih-at/libzip#105 makes some sense, so we should at most fix this temporarily for BC reasons (i.e. this patch should target PHP-7.3+). In the long run (PHP 9?) we're likely better off to accept the behavioral change.

@remicollet
Copy link
Member Author

remicollet commented Mar 20, 2020

@cmb69 thanks for your feedback which confirm my feeling.

Applied in 7.3+
Deprecattion added for 8.0 in a4d12f4

@remicollet remicollet closed this Mar 20, 2020
@remicollet remicollet deleted the issue-79296 branch March 20, 2020 10:29
alcalbg referenced this pull request in filegator/filegator May 11, 2020
@alcalbg
Update README.md
a80fdbe
alcalbg referenced this pull request in filegator/filegator May 11, 2020
@alcalbg
fix/test: create empty zip archive is futile
cbdab39
@t-schroeder t-schroeder mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remicollet @cmb69