Skip to content

Conversation

@ranvis
Copy link
Contributor

@ranvis ranvis commented Dec 17, 2019

When configured with a path specified.

When configured with a path specified.
@cmb69
Copy link
Member

cmb69 commented Dec 17, 2019

Hmm, which library distribution do you use?

Also, please note that PHP-7.2 is no longer actively supported, so the PR has to target PHP-7.3.

@ranvis
Copy link
Contributor Author

ranvis commented Dec 17, 2019

From this URL:
https://www.enterprisedb.com/downloads/postgres-postgresql-downloads
SHA1(postgresql-12.1-1-windows-x64.exe)= 4c79e8d1457387eeecc083d44e55151a27bc4ac7

Also, please note that PHP-7.2 is no longer actively supported, so the PR has to target PHP-7.3.

I'm sorry.
I've referenced https://github.com/php/php-src/blob/master/CONTRIBUTING.md but it is out of date then.
Should I close and repost the PR's?

@cmb69
Copy link
Member

cmb69 commented Dec 17, 2019

Ah, indeed, the PostgreSQL distribution has this folder structure (I'm having version 10).

And, yes, that README.mdCONTRIBUTING.md is not up-to-date; I shall fix it. There is no need to make a new PR; you can simply rebase onto PHP-7.3 (should be possible via Github; just press Edit beside the PR title).

@ranvis ranvis changed the base branch from PHP-7.2 to PHP-7.3 December 17, 2019 18:55
@cmb69
Copy link
Member

cmb69 commented Dec 19, 2019

Thanks for the PR! It seems to me that the AppVeyor test failures are unrelated, so I've applied this as 3e35b08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants