Skip to content

Fix #78982: pdo_pgsql returns dead persistent connection #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ranvis wants to merge 1 commit into from
Closed

Fix #78982: pdo_pgsql returns dead persistent connection #5021

ranvis wants to merge 1 commit into from

Conversation

@ranvis
Copy link
Contributor

@ranvis ranvis commented Dec 17, 2019

Call PQconsumeInput() before PQstatus() to update the status.

@ranvis
Fix #78982: pdo_pgsql returns dead persistent connection
4851117 
Call PQconsumeInput() before PQstatus() to update the status.
@cmb69 cmb69 added the Bug label Dec 17, 2019
@ranvis ranvis changed the base branch from PHP-7.2 to PHP-7.3 December 17, 2019 18:56
nikic
nikic approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:
PQstatus: https://github.com/postgres/postgres/blob/f14413b684d57211068ee56ee04695efcc87a23a/src/interfaces/libpq/fe-connect.c#L6573-L6579
PQconsumeInput: https://github.com/postgres/postgres/blob/e75b1e33710249d1699850920c0390fb08ea5673/src/interfaces/libpq/fe-exec.c#L1703-L1731

@nikic
Copy link
Member

nikic commented Dec 20, 2019

Merged as 37d11d1.

@nikic nikic closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ranvis @nikic @cmb69