Fixed bug #77978 #4835
Closed
Fixed bug #77978 #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong relative path on unpacking zip archives with ".","..",":" character sequences on different platforms. The fix tries to separate Windows absolute paths from Unix paths that might contain a colon just before an slash relaying on the fact that the semicolon on windows absolute paths is always in the same position. There might be a case for a relative Unix path that might look like a windows absolute path (x:\foo\bar) that might result in chopping the leading path (x:). I think this is acceptable and an improvement over the current bug in order to avoid using different conditions per operating system. This could result in different extraction paths depending on the OS, what might generally be undesirable, and could cause BC issues. This is partially based on PR #4160 and its comments.
Member
|
CI failed on Linux and Windows. Could you please have a look @IGedeon? |
Member
|
The CI test failures still have not been resolved, so I'm closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong relative path on unpacking zip archives with ".","..",":" character sequences
on different platforms. bug #77978
The fix tries to separate Windows absolute paths from Unix paths that might contain a colon just before an slash relaying on the fact that the semicolon on windows absolute paths is always in the same position.
There might be a case for a relative Unix path that might look like a windows absolute path (x:\foo\bar) that might result in chopping the leading path (x:). I think this is acceptable and an improvement over the current bug in order to avoid using different conditions per operating system. This could result in different extraction paths depending on the OS, what might generally be undesirable, and could cause BC issues.
This is partially based on PR #4160 and its comments.