Skip to content

fix #78624: session_gc return value for user defined session handlers #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bshaffer wants to merge 1 commit into from
Closed

fix #78624: session_gc return value for user defined session handlers #4775

bshaffer wants to merge 1 commit into from

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Oct 2, 2019 •
edited
Loading

session_gc returns false for all user-defined session handlers.

It should return the number of deleted records, OR 1, when the user-defined session handler returns true.

repro case

Fixes https://bugs.php.net/bug.php?id=78624

@dwsupplee for credit in tracking down the issue

@krakjoe krakjoe added the Bug label Oct 3, 2019
@krakjoe
Copy link
Member

krakjoe commented Oct 4, 2019

Merged as a6d2196

Thanks.

@krakjoe krakjoe closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bshaffer @krakjoe