Skip to content

Fix #78609: mb_check_encoding() no longer supports stringable objects #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmb69 wants to merge 1 commit into from
Closed

Fix #78609: mb_check_encoding() no longer supports stringable objects #4757

cmb69 wants to merge 1 commit into from

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 30, 2019

We apply type juggling for other types than array.

For PHP 7.4+ we have to try_convert_to_string() instead.

@cmb69
Fix #78609: mb_check_encoding() no longer supports stringable objects
63374fa 
We apply type juggling for other types than array.
@cmb69 cmb69 requested a review from nikic September 30, 2019 09:14
@cmb69
Copy link
Member Author

cmb69 commented Sep 30, 2019

Thanks! Applied as 45db6fa.

@cmb69 cmb69 closed this Sep 30, 2019
@cmb69 cmb69 deleted the fix-78609 branch September 30, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmb69 @nikic