Fix #78543: is_callable() on FFI\CData throws Exception #4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Z_OBJ_HANDLER_P(callable, get_closure)` throws, we must not let the exeception pass to userland, if called through `is_callable()`.
Member
|
This looks good for PHP-7.4. For master, it might be better to extend get_closure() with additional argument and prevent exception throwing in first place. |
Member
Author
|
Thanks @dstogov! So cmb69/php-src@9db334e for master? |
Member
|
Oh, I didn't mean master must be fixed in different way immediately. |
Member
Author
|
No problem. Take your time; I'll leave that branch open. Merged into PHP 7.4 as 9dfbcd7 and added a TODO comment for master. |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Z_OBJ_HANDLER_P(callable, get_closure)throws, we must not let theexeception pass to userland, if called through
is_callable().