Fix #78438: Corruption when __unserializing deeply nested structures #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When storing two temporary variables for delayed __unserialize() calls, we have to make sure that both fit into the same linked list element. We also remove `VAR_DTOR_ENTRIES_MAX` completely in favor of `VAR_ENTRIES_MAX`.
nikic
reviewed
Aug 22, 2019
nikic
approved these changes
Aug 23, 2019
Member
Author
|
Thanks! Applied as ca265eb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storing two temporary variables for delayed __unserialize() calls,
we have to make sure that both fit into the same linked list element.
We also remove
VAR_DTOR_ENTRIES_MAXcompletely in favor ofVAR_ENTRIES_MAX.