Fix #78386: fstat mode has unexpected value on PHP 7.4 #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not assume that any file which is not a directory is a regular file. Therefore we employ `GetFileType()` in this case to properly distinguish between character special, FIFO special and regular files.
Member
Author
|
While doing further edge-case testing, I've stumbled upon bug #78220, so finishing this PR may take a while. |
KalleZ
approved these changes
Aug 9, 2019
Member
Author
|
Further testing showed no issues, so applied as c03114e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not assume that any file which is not a directory is a regular
file. Therefore we employ
GetFileType()in this case to properlydistinguish between character special, FIFO special and regular files.