Skip to content

Fix #78202: Opcache stats for cache hits are capped at 32bit NUM #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cmb69 wants to merge 6 commits into from
Closed

Fix #78202: Opcache stats for cache hits are capped at 32bit NUM #4307

cmb69 wants to merge 6 commits into from

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Jun 25, 2019

Since the respective variables are declared as zend_ulong we have to
also format them as such.

@cmb69
Fix #78202: Opcache stats for cache hits are capped at 32bit NUM
121727f 
Since the respective variables are declared as `zend_ulong` we have to
also format them as such.
@cmb69
Copy link
Member Author

cmb69 commented Jun 25, 2019

The free and wasted memory below are size_t values, and have to be formatted as such. Not sure about our convention here. Is "zu" appropriate?

@nikic
Copy link
Member

nikic commented Jun 25, 2019

The free and wasted memory below are size_t values, and have to be formatted as such. Not sure about our convention here. Is "zu" appropriate?

Yeah, zu is the right one for that.

@cmb69
Copy link
Member Author

cmb69 commented Jun 25, 2019

Hmm, seems Azure Pipelines CI is not triggered?

@krakjoe
Copy link
Member

krakjoe commented Jun 25, 2019

azure will only be triggered for 7.4+

@krakjoe
Copy link
Member

krakjoe commented Jun 25, 2019

@cmb69 if it's important to see something on azure, open a pull request against 7.4 maybe ? or just wait for the merge (and watch the pipeline) if you're pretty confident nothing is wrong ...

@cmb69
Copy link
Member Author

cmb69 commented Jun 25, 2019

Thanks @krakjoe! I think the changes of this PR (MINFO) are not tested anyway.

@krakjoe
Copy link
Member

krakjoe commented Jun 25, 2019

Ah I just done the extra click to see what had changed ... yeah, ship it, more CI isn't buying you anything ...

@cmb69
Copy link
Member Author

cmb69 commented Jun 25, 2019

Applied as 4366f22.

Thanks!

@cmb69 cmb69 closed this Jun 25, 2019
@cmb69 cmb69 deleted the fix-78202 branch June 25, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmb69 @nikic @krakjoe