Fix bug #78197: PCRE2 version check #4296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When external PCRE library version is of format ##.##-RC# the check failed.
nikic
reviewed
Jun 24, 2019
nikic
reviewed
Jun 25, 2019
ext/pcre/config0.m4
Outdated
| AC_MSG_CHECKING(for PCRE2 10.30 or greater) | ||
| PCRE2_VER=`$PCRE2_CONF --version` | ||
| if test "`echo $PCRE2_VER | sed 's,\.,,g'`" -lt 1030; then | ||
| if test "`echo $PCRE2_VER | $SED 's/\([[0-9]]*\)\.\([[0-9]]*\)\(.\)*/\1\2/g'`" -lt "1030"; then |
Member
There was a problem hiding this comment.
I think the first two * should be + here. Also, why \(.\)* rather than just .*?
Member
Author
There was a problem hiding this comment.
The + would work if sed -r would be used (regular expressions) which is on MacOS and FreeBSD sed -E option:
http://www.grymoire.com/Unix/Sed.html#uh-4a
The last asterisk has been fixed and simplified into .*...
nikic
approved these changes
Jun 25, 2019
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When external PCRE library version is of format
##.##-RC#the check failed.Merge to PHP-7.4 and up with: