Fix bug #76801: phpdbg too many open files error #3965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
047fce9 to
983c982
Compare
Member
Member
|
We did have a quick review, the find_ptr looks suspect and may result in list output being out of sync with the file as compiled. Bob couldn't remember the details of why we had the fake handle in the first place ... I would say drop the find_ptr and it's good to merge, and we'll see what breaks with regard to the fake handle ... |
Contributor
Author
|
Ok, I removed the find_ptr. I wasn’t considering that sources could be modified during execution. |
krakjoe
approved these changes
Mar 23, 2019
Member
|
Merged b8b8809 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://bugs.php.net/bug.php?id=76801 which prevented phpdbg to release file handles and causing "too many open files" error to be raised when testing a medium sized project.
phpdbg_compile_filewas rewritten, no more requiring a fake file handle to be created