mb_str_split without any mbfl modifications PR3715 related#3808
mb_str_split without any mbfl modifications PR3715 related#3808legale wants to merge 18 commits intophp:masterfrom
Conversation
ff56509 to
a501664
Compare
Tests for __set_state magic method for DateTime, DateTimeImmutable, DateTimeZone and DatePeriod.
|
Why windows tests are so unstable??? |
This reverts commit b743eab.
This reverts commit 7b109cd.
|
@nikic, @guilliamxavier, @IMSoP https://www.ietf.org/rfc/rfc2781.txt So there is no valid character for the 0xDC00 (first low surrogate). I think that in such cases, decoder should skip the character as it is, but the mbfl library decoder changes it. |
|
@legale As mentioned on https://bugs.php.net/bug.php?id=77607, invalid character being replaced with |
|
So it is not a bug, it is a feature?
…On Tue, Feb 12, 2019, 11:07 Nikita Popov ***@***.*** wrote:
@legale <https://github.com/legale> As mentioned on
https://bugs.php.net/bug.php?id=77607, invalid character being replaced
with ? or some other substitution character is expected behavior here
(the problem is actually that the same does not happen for UTF-8 due to the
table optimization, but that's a much more general issue than just this
function).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3808 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AfHEl0v8ZYsR1H94MfOuhnSQoZArXc62ks5vMpJrgaJpZM4ayc-d>
.
|
|
@legale Yes ;) |
|
When compiling this just now, I got a bunch of warnings: |
|
@nikic Did we've finished? |
|
Merged as d77ad27 into 7.4+, with some style fixes. In particular, note that C code in php-src uses tab indentation, not space indentation. Thanks for seeing this through :) |
|
Thank you for this RFC. It is the true answer to my Stack Overflow question: https://stackoverflow.com/questions/55782088/convert-a-string-into-an-array-of-characters-multi-byte |
|
You are welcome :-)
вс, 28 апр. 2019 г., 1:43 Kamil Tekiela <notifications@github.com>:
… Thank you for this RFC. It is the true answer to my Stack Overflow
question:
https://stackoverflow.com/questions/55782088/convert-a-string-into-an-array-of-characters-multi-byte
It has passed my UTF-8 test according to my expectations:
https://3v4l.org/M85Fi/rfc#output
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3808 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHY4JFZH6P2RUFZCCDJ5EKDPSTQL3ANCNFSM4GWJZ6OQ>
.
|
mb_str_split without any mbfl modifications
This PR is related to #3715