Skip to content

Conversation

@cmb69
Copy link
Member

@cmb69 cmb69 commented Feb 8, 2019

Since we're putting ITypeLib *s into the hash, we're getting
ITypeLib *s back, not ITypeLib **s.

Since we're putting `ITypeLib *`s into the hash, we're getting
`ITypeLib *`s back, not `ITypeLib **`s.
@cmb69 cmb69 requested a review from weltling February 8, 2019 13:36
@cmb69
Copy link
Member Author

cmb69 commented Feb 8, 2019

Since the segfault happens on module shutdown, a PHPT likely makes no sense.

@krakjoe
Copy link
Member

krakjoe commented Feb 8, 2019

Each test is run it's own process, I think you can test for it ...

@cmb69
Copy link
Member Author

cmb69 commented Feb 8, 2019

@krakjoe Yes, a test could be as simple as:

ini_set('com.autoregister_typelib', 1);
new COM('WbemScripting.SWbemLocator');
echo 'DONE';

But even without this fix, the shutdown issue would not be noticable (except when actually running a debugger), since we have no valgrind support on Windows.

@krakjoe
Copy link
Member

krakjoe commented Feb 8, 2019

I see ... I'll shut up ... am allergic to and bad at windows :)

@cmb69
Copy link
Member Author

cmb69 commented Mar 17, 2019

@weltling Any objections to merging this?

Copy link
Contributor

@weltling weltling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmb69 looks good, but please add a test if possible. For that, you might want to call PHP in a sub process and check exit status.

Thanks.

@cmb69
Copy link
Member Author

cmb69 commented Mar 18, 2019

For that, you might want to call PHP in a sub process and check exit status.

Ah, thanks!

Applied as 41bc51c.

@cmb69 cmb69 closed this Mar 18, 2019
@cmb69 cmb69 deleted the bug-77578 branch March 18, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants