Fix #75282: xmlrpc_encode_request() crashes #3591
Closed
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we allow ext/xmlrpc to be built against a system libxmlrpc(-epi), we must not `efree` memory which has been allocated via `malloc`. To distinguish bundled and system libxmlrpc(-epi) we introduce the macro `HAVE_XMLRPC_BUNDLED` (analogous to how it is done by ext/gd). We deliberately keep the ugly `#ifdef`s, instead of tucking them away in an `XMLRPC_FREE()` macro, to not forget that it is a bad idea to fork and bundle a library, but to also allow building against an unpatched system lib.
Member
Author
|
@oerdnj This is supposed to get rid of the Revert "libxmlrc uses system malloc instead of PHP alloc routines" patch. Can you please confirm? |
nikic
reviewed
Oct 7, 2018
Other tests using `xmlrpc_encode_request()` already exhibit the issue.
|
Comment on behalf of petk at php.net: Labelling |
Member
Author
|
Unless there are objections, I'm going to merge this on the next weekend. |
|
Comment on behalf of cmb at php.net: Applied via 502b187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we allow ext/xmlrpc to be built against a system libxmlrpc(-epi),
we must not
efreememory which has been allocated viamalloc. Todistinguish bundled and system libxmlrpc(-epi) we introduce the macro
HAVE_XMLRPC_BUNDLED(analogous to how it is done by ext/gd). Wedeliberately keep the ugly
#ifdefs, instead of tucking them away inan
XMLRPC_FREE()macro, to not forget that it is a bad idea to forkand bundle a library, but to also allow building against an unpatched
system lib.