Fix #76965: INI_SCANNER_RAW doesn't strip trailing whitespace #3572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrary to `INI_SCANNER_NORMAL` and `INI_SCANNER_TYPED`, `INI_SCANNER_RAW` didn't strip whitespace at the end of the line, or before a line comment, which is undesirable. It is a particular problem if the value is enclosed in double-quotes, since in this case the quotes didn't get stripped.
Member
Author
|
Hmm, that breaks bug51094.phpt. Reading the reasoning for the fix of https://bugs.php.net/63512, it seems the current behavior is intended (at least for BC reasons). @adoy What do you think? |
Member
|
@cmb69 I don't think the current behavior, where |
Member
Member
Member
Author
|
@adoy This looks way better than my attempt. Thanks! I'm closing this PR, so you can submit your solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to
INI_SCANNER_NORMALandINI_SCANNER_TYPED,INI_SCANNER_RAWdidn't strip whitespace at the end of the line, orbefore a line comment, which is undesirable. It is a particular
problem if the value is enclosed in double-quotes, since in this case
the quotes didn't get stripped.