Store zlog stream in each child so it can be reused #3471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change results in using the same buffer for multiple stdio events which should fix inconsistencies of handling messages that are not ended with a new line and possibly very long messages that are split to multiple events.
Member
Author
|
The Travis fail was unrelated so it's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the same buffer for multiple stdio events which should fix inconsistencies of handling
messages that are not ended with a new line and possibly very long messages that are split to multiple events. It also means that the max memory used for zlog streams is
log_limitmultiple by number of workers which should be fine if the value is not set way too high which probably doesn't make sense anyway.If CI is green, I will merge it shortly so it's in the next beta.