Skip to content

Fixed #76754: parent private constant in extends class memory leak #3447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
twose wants to merge 2 commits into from
Closed

Fixed #76754: parent private constant in extends class memory leak #3447

twose wants to merge 2 commits into from

Conversation

@twose
Copy link
Member

@twose twose commented Aug 16, 2018

memory leak here, the size of the sub class's constants table should be added by the parent constants table size without private constants.

<?php
 class FOO
{
    private const FOO = 'BAR';
}
 class BAR extends FOO { }

@twose twose changed the title Private const extends Fixed #76754: parent private constant in extends class memory leak Aug 16, 2018
@twose twose force-pushed the private_const_extends branch from 66e9f70 to bd8a640 Compare August 17, 2018 01:52
@twose twose force-pushed the private_const_extends branch from bd8a640 to 7d59c37 Compare August 17, 2018 09:03
@twose
Copy link
Member Author

twose commented Aug 17, 2018

@laruence
I notice you have fixed it in bugs.php.net.
if check the correct constants table size is better? or you can close this pr.

@smalyshev smalyshev added the Bug label Aug 26, 2018
@smalyshev smalyshev requested a review from laruence August 26, 2018 23:53
@laruence
Copy link
Member

laruence commented Aug 27, 2018

Hmm, sorry, didn't notice this PR before, anyway, I think the committed way is better, since similar memory also could leak in extension classes

@laruence laruence closed this Aug 27, 2018
@twose twose deleted the private_const_extends branch August 27, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laruence laruence Awaiting requested review from laruence

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twose @laruence @smalyshev