Skip to content

Conversation

@kabel
Copy link
Contributor

@kabel kabel commented Jul 9, 2018

No description provided.

.P
.B http://php.net/manual/book.phpdbg.php
.P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty new line here can be omitted so it doesn't cause issues in output.

.P
.B http://bugs.php.net/
.P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty new line here can be omitted so it doesn't cause issues in output.

.PD 0
.P
.B http://bugs.php.net/
.P
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .P should be .PD 1

.PD 0
.P
.B http://php.net/manual/book.phpdbg.php
.P
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .P should be .PD 1

@petk
Copy link
Member

petk commented Aug 2, 2018

Hello, thanks for the pull request @kabel. This one looks good 👍 I've tested it out. Few new line fixes and I think we can add it to the PHP 7.1 and up.

Also it would be useful to additionally add this to .gitignore:

sapi/phpdbg/phpdbg.1

@php-pulls
Copy link

Comment on behalf of petk at php.net:

Applied via 91996e7 Thank you @kabel

@php-pulls php-pulls closed this Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants