Add fpm_get_request_headers function #3373
Conversation
|
Given that we already have |
|
It just seems strange to name function |
Indeed, but this is how other SAPI define the function
Could be the way to go. |
|
I have added apache_request_headers() to the list of potential PHP 7.4 deprecations at https://wiki.php.net/rfc/deprecations_php_7_4#apache_request_headers_function so we don't forget about it. I think there is nothing actionable for us to do in PHP 7.3 though, so I'd suggest closing this PR. |
|
@nikic Cool! |
With addition of
fpm_get_statuswe have an FPM specific function and it would be nice to have a function named in that way for getting request headers. The PR is more a cosmetic follow up to #3363 . One reason for that is to have a section in php-doc FPM documentation about its functions. I think thatapache_request_headersis quite confusing as this has nothing to do with Apache in this case but kept it as an alias.