When print failed, exit with 255 #3306
Conversation
| { | ||
| ret = sapi_cli_single_write(ptr, remaining); | ||
| if (!ret) { | ||
| #ifndef PHP_CLI_WIN32_NO_CONSOLE |
There was a problem hiding this comment.
The removal of this macro seems wrong.
There was a problem hiding this comment.
I look php_handle_aborted_connection through, it works with PHP_CLI_WIN32_NO_CONSOLE.
When at Win32, why not call php_handle_aborted_connection?
There was a problem hiding this comment.
In addition to the usual php.exe there is a binary variant php-win.exe dedicated to specifically have no console I/O.
Thanks.
|
@cmb69 you'll want to look at this one ... |
| size_t ret; | ||
| ssize_t ret; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
It seems to me that we should declare ssize_t ret; unconditionally.
|
In my opinion, we should:
Otherwise, looks good to me. |
a86f58d to
0abc7af
Compare
|
|
Thanks!
Well, the ticket claims that “Output after stdout/stderr closed cause immediate exit”, what would not be fixed by this pull request. The fix here is merely that an appropriate exit code code is set (which is good in my opinion). Anyway, if there are no objections, I'm going to apply this fix before 7.3.0alpha2 is tagged (presumably next Tuesday). |
|
Comment on behalf of cmb at php.net: Thanks! Applied via ecc1a7c. |
fix https://bugs.php.net/bug.php?id=44217