Fix #65547: Default value for sunrise/sunset zenith still wrong #3088
Conversation
The value of the zenith angle to calculate sunrise and sunset times is commonly defined as 90°50', and is "obtained by adding the average apparent radius of the Sun (16') to the average amount of atmospheric refraction at the horizon (34')", according to http://aa.usno.navy.mil/faq/docs/RST_defs.php. This value is also used for the Sunrise/Sunset Algorithm published in the Almanac for Computers, 1990, see https://web.archive.org/web/20161202180207/http://williams.best.vwh.net/sunrise_sunset_algorithm.htm.
|
@cmb69 target master please ... |
|
Only if master is PHP 8 will I approve this. |
|
I was trying to be reasonable ... this is a bug fix in my opinion and is fine to target active branches, as a bug fix. Targeting the next minor should give plenty of time for those people relying on broken internals to prepare themselves, shouldn't it ? |
|
Well, this is only about changing default ini settings (which are even I can fix |
|
Changed base to master as requested. |
|
This appears to be too controversial for PHP 7, so I'm closing this PR. https://bugs.php.net/65547 is still open as a reminder to tackle the issue for PHP 8. |
The value of the zenith angle to calculate sunrise and sunset times is
commonly defined as 90°50', and is "obtained by adding the average
apparent radius of the Sun (16') to the average amount of atmospheric
refraction at the horizon (34')", according to
http://aa.usno.navy.mil/faq/docs/RST_defs.php.
This value is also used for the Sunrise/Sunset Algorithm published in
the Almanac for Computers, 1990, see
https://web.archive.org/web/20161202180207/http://williams.best.vwh.net/sunrise_sunset_algorithm.htm.