Skip to content

Conversation

@villfa
Copy link
Contributor

@villfa villfa commented Oct 28, 2017

Fix for bug 75434

@villfa villfa changed the base branch from master to PHP-7.0 October 28, 2017 08:17
@krakjoe krakjoe added the Bug label Oct 28, 2017
@nikic
Copy link
Member

nikic commented Oct 28, 2017

For the future, it's really not necessary to include tests for arginfo changes. They're not going to catch regressions, and the arginfo mechanism itself is already well-tested. Feel free to save the extra effort there :)

@nikic
Copy link
Member

nikic commented Oct 28, 2017

Merged as 938f256 into 7.0+. Thanks!

@nikic nikic closed this Oct 28, 2017
@villfa villfa deleted the fix/75434 branch October 28, 2017 11:45
@ohartl
Copy link

ohartl commented Oct 28, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants