Skip to content

Conversation

@petk
Copy link
Member

@petk petk commented Oct 1, 2017

This patch fixes bug #75301.

@remicollet
Copy link
Member

Quite strange, since 7.1, nealy all extensions should have switched to PHP_VERSION... 1.4 doesn't make sense. (with some exceptions like oci8 or zip)

@petk
Copy link
Member Author

petk commented Oct 2, 2017

Thanks @remicollet for this info. Yes, particular version besides the PHP_VERSION for extensions in the core might be confusing unless they are developed separately using PECL or something. I'll go through the extensions and fix those versions for the PHP-7.1 and up. Makes more sense now with knowing this... Would it be better to leave this PR as it is or to start with PHP_VERSION and change the target branch to PHP-7.1?

@krakjoe krakjoe added the Bug label Oct 3, 2017
@cmb69
Copy link
Member

cmb69 commented Oct 3, 2017

In my opinion, it would be best to set the version to PHP_VERSION and to target PHP-7.0 – after all, it is a bug(fix). Cf. c3b9103.

@KalleZ
Copy link
Member

KalleZ commented Oct 4, 2017

Hi

As the exif extension maintainer, I would prefer that we either go with PHP's current version or simply "NO_VERSION_YET" in the module struct. It will be some time before I can do this myself so I'm open for changing this.

-K

@petk petk force-pushed the patch-exif-revision branch from 22d3b7c to 74124de Compare October 4, 2017 21:34
@petk
Copy link
Member Author

petk commented Oct 4, 2017

In above commit the PHP_VERSION is now used instead of the $Id$.

@KalleZ
Copy link
Member

KalleZ commented Oct 4, 2017

Thanks @petk, LGTM

@php-pulls php-pulls merged commit 74124de into php:PHP-7.0 Oct 11, 2017
@petk petk deleted the patch-exif-revision branch October 11, 2017 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants