Bcscale return old value #2739
Merged
Bcscale return old value #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #67855
The `scale` parameter is now optional.
nikic
reviewed
Sep 7, 2017
| } | ||
|
|
||
| RETURN_TRUE; | ||
| RETURN_LONG(old_scale); |
Member
There was a problem hiding this comment.
Given that this function always returned true, so the return value was meaningless, I'd say this should go into 7.2.
Member
Author
There was a problem hiding this comment.
@remicollet, @sgolemon Okay to merge into PHP 7.2?
Member
Author
|
Since this certainly isn't a necessary feature (one can store the bscale value by other means) I think there's no need to hurry, so I'm going to merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements https://bugs.php.net/bug.php?id=67855 based on PR #778.
TL;DR:
bcsale()now can be called without a parameter to get the current scale value, and returns the old scale value if called as setter.Note that this would need an entry in UPGRADING.