Skip to content

BUG #74737: Incorrect ReflectionFunction information for mysqli_get_c… #2579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhagstrand wants to merge 1 commit into from
Closed

BUG #74737: Incorrect ReflectionFunction information for mysqli_get_c… #2579

mhagstrand wants to merge 1 commit into from

Conversation

@mhagstrand
Copy link
Contributor

@mhagstrand mhagstrand commented Jun 15, 2017

…lient_info

The $link parameter for mysqli_get_client_info was showing as required from reflection, but it is an optional parameter.

https://bugs.php.net/bug.php?id=74737

@nikic
Copy link
Member

nikic commented Jun 15, 2017

According to

php-src/ext/mysqli/mysqli_api.c

Line 1376 in 703209f

/* {{{ proto string mysqli_get_client_info(void)
this function does not take parameters.

@mhagstrand
Copy link
Contributor Author

mhagstrand commented Jun 15, 2017 •
edited
Loading

Yeah I did see that, but it can according to the docs take an optional parameter.
http://php.net/manual/en/mysqli.get-client-info.php

I didn't want to make a BC breaking change in case a someone was passing in the $link parameter.

@nikic
Copy link
Member

nikic commented Jun 15, 2017

Passing in additional parameters will still be supported, as the implementation does not use zend_parse_parameters_none().

@mhagstrand
Copy link
Contributor Author

mhagstrand commented Jun 15, 2017

So do you think I should use arginfo_mysqli_no_options and remove the arginfo_mysqli_optional_link?

@nikic
Copy link
Member

nikic commented Jun 15, 2017

Yeah, that would make the most sense to me.

@mhagstrand
Copy link
Contributor Author

mhagstrand commented Jun 15, 2017

I have made those changes. Thanks for the input.

@php-pulls
Copy link

php-pulls commented Jun 20, 2017

Comment on behalf of pollita at php.net:

eea4b0b

@php-pulls php-pulls closed this Jun 20, 2017
@carusogabriel
Copy link
Contributor

carusogabriel commented Feb 13, 2018

This bug is still open in https://bugs.php.net/bug.php?id=74737

@nikic
Copy link
Member

nikic commented Feb 13, 2018

@carusogabriel Thanks, closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhagstrand @nikic @php-pulls @carusogabriel