fix bug #73471 PHP freezes with AppendIterator #2499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@krakjoe is there any problem with this PR? |
Member
|
Merged 81c2a4b Thanks. |
Contributor
|
This breaks my code: https://3v4l.org/itLi1 |
Member
|
@gharlan Please report on bugs.php.net. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug #73471 PHP freezes with AppendIterator
the
spl_append_it_next_iteratorcall insideAppendIterator::append(Iterator it)copy the current data ofintern->u.append.iteratortointern->inner.zobject(see here), which leads to an infinite loop here