Skip to content

Fix #69579: Invalid free with internal trait (2) #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbboehr wants to merge 2 commits into from
Closed

Fix #69579: Invalid free with internal trait (2) #2139

jbboehr wants to merge 2 commits into from

Conversation

@jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Sep 22, 2016 •
edited
Loading

If you are fixing a bug, then please submit your PR against the lowest branch of PHP that the bug affects

787377b works in 7.0, but f9b7bd0 is modeled after 2ee73ee

This PR includes the change from #1262, plus a test case and an internal test trait. I set up a Travis build to demonstrate what happens:
https://travis-ci.org/jbboehr/php-psr/jobs/161807370#L956
https://travis-ci.org/jbboehr/php-psr/jobs/161807373#L954

@KalleZ
Copy link
Member

KalleZ commented Sep 22, 2016

I think the patch looks good, except that we don't implement test code like that in C, not sure if you got an easier way to test it, since we do not have an internal trait by default in the php-src distro

cc one of @dstogov / @nikic / @laruence

@jbboehr
Copy link
Contributor Author

jbboehr commented Sep 22, 2016 •
edited
Loading

except that we don't implement test code like that in C

Not to be contrary, but 2ee73ee appears to do just that: https://github.com/php/php-src/search?utf8=%E2%9C%93&q=_ZendTestClass

@nikic
Copy link
Member

nikic commented Sep 22, 2016

Merged via 8e313be into 7.0 and upwards. Thanks!

@nikic nikic closed this Sep 22, 2016
@nikic nikic mentioned this pull request Sep 22, 2016
Closed
@jbboehr jbboehr mentioned this pull request Aug 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikic nikic nikic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbboehr @KalleZ @nikic