Fix #70315: imagecreatefromstring() returns Server Error but page is … #1991
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR superses PR #1990. |
Member
Author
|
@pierrejoye Okay to merge (to PHP 5.6+)? See also the slightly more detailed analysis in https://bugs.php.net/bug.php?id=70315. |
That happens because the external libgd uses other error codes than PHP (and the bundled libgd), but the libgd error codes are simply forwarded to php_verror(). We fix that by properly mapping libgd errors to PHP errors.
Member
Author
|
The failing checks seem to be unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rendered
That happens because the external libgd uses other error codes than PHP
(and the bundled libgd), but the libgd error codes are simply forwarded
to php_verror(). We fix that by properly mapping libgd errors to PHP errors.
As already mentioned in the bug report, this doesn't necessarily mean that external and bundled libgd behave identically now, but at least we avoid inconsistencies like the one reported. Fixing the bundled libgd to match external libgd is probably best done for PHP 7.1.0 only.
Another issue is that most likely some PHPTs will fail after this change (when run again an external libgd PHP build), but there are already plenty of failing tests in this case now (I got 43 with and without the patch).