Change default gd.jpeg_ignore_warning = 1 #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring these warnings apparently works fine (libgd does so in gdImageCreateJpeg()), but not ignoring them may cause imagecreatefromjpeg() to fail completely, so it seems reasonable to ignore warnings by default. Note that this change most likely doesn't constitute a BC break; we're simply being more resilient with regard to slightly broken JPEGs. See also the related [bug #72404](https://bugs.php.net/bug.php?id=72404).
Member
Author
|
The failing Travis checks appear to be unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring these warnings apparently works fine (libgd does so in
gdImageCreateJpeg()), but not ignoring them may cause imagecreatefromjpeg()
to fail completely, so it seems reasonable to ignore warnings by default.
Note that this change most likely doesn't constitute a BC break; we're
simply being more resilient with regard to slightly broken JPEGs.
See also the related bug #72404.
I don't think this change requires an RFC, but if others feel otherwise I can make one.
If the PR will be accepted, I'll change the documentation accordingly.