Fixed bug #72096 Swatch time value incorrect for dates before 1970 #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/cc @derickr |
ext/date/tests/bug72096.phpt
Outdated
| } | ||
| ?> | ||
| --EXPECT-- | ||
| Time:2016-04-22 00:00:00 = 041 Time:1934-03-04 00:00:00 = 041 |
Member
There was a problem hiding this comment.
I'd change the test to do the following:
- output the pre-1970 one on the next line
- explicityly set the timezone in an
--INI--setting toUTC - Not use a constant like "25920000000" but instead do "365 * 24 * 3600" (etc) to show where it comes from
- Add a
:between theBug #72096andSwatch timein the title
Member
|
I've added some comments. |
Contributor
Author
|
@derickr any feedback on this? |
Member
|
LGTM |
Member
|
@derickr can I ask that you personally merge this into appropriate branches as you see fit, please: While we don't have tests that rely on the old behaviour, it's not impossible that someone does have code that does, I would suppose (and I may be wrong). |
Member
|
Merged via b224e74 into PHP 7.0+. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=72096