Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is:
php_set_session_var may cause http_session_vars resize, which will make the var in var_hash->data become invalid..
I propose to fix this by prepend a magic var "__SESS_N_VARS" to session serialized string, with this, we could know how many vars there before doing session decoding, and extend PS(http_session_vars) to the proper size, thus can avoding hash table resize, as this is a little tricky , so I make PR instead of pushing it directly.
thanks