Fix bug #71897 (ASCII 0x7F Delete control character permitted in identifiers) #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test I wrote seems to trigger a memory leak in OPcache. I doubt that's the fault of my patch, though. |
1226515 to
8cc65f3
Compare
| - Core: | ||
| . 'void' can no longer be used as the name of a class, interface, or trait. | ||
| This applies to declarations, class_alias() and use statements. | ||
| . The ASCII 0x7F Delete control character is no longer permitted in unquoted |
Contributor
Author
There was a problem hiding this comment.
I hope "unquoted identifiers" is reasonably clear, but I'm open to suggestions for better wording. I want to express that it covers $a␡b and a␡b but not ${"a\x7Fb"} or constant("a\x7Fb").
Member
|
You should bring this up on the list. It seems like a mistake to me as well, but who knows... |
Contributor
Author
|
Ah, good idea, if anyone knows it'll be someone on internals. |
Contributor
Author
|
Nobody seems to have objected. Should this be merged, then? |
Member
|
Go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bug page for details: https://bugs.php.net/bug.php?id=71897
There's a corresponding php-langspec pull request: php/php-langspec#156
There's a possibility that allowing ␡ is intentional, and if that's the case then we probably shouldn't merge this "fix".