arc4random_buf on OpenBSD for random bytes instead of opening /dev/arandom#1769
Closed
iwanluijks wants to merge 2 commits intophp:masterfrom
iwanluijks:php-session-create-id-arc4random
Closed
arc4random_buf on OpenBSD for random bytes instead of opening /dev/arandom#1769iwanluijks wants to merge 2 commits intophp:masterfrom iwanluijks:php-session-create-id-arc4random
iwanluijks wants to merge 2 commits intophp:masterfrom
iwanluijks:php-session-create-id-arc4random
Conversation
…n unnecessary file descriptor for randomization.
Contributor
|
Could you please rewrite this patch using php_random_bytes() which is available since 7.0 and already takes care about these platform details? Thanks. |
Author
|
Great suggestion, that also cleans up the ugly mess of code in the php_create_session_id. I'll get back with a pull request when it is ready. |
Member
|
Thank you for resubmitting a PR according to what has been said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the php_session_create_id function a file descriptor is opened to the configured session.entropy_file by default, on non-Windows OSs and OSs that don't have an entropy_file available at compile time.
This is effectively described in the comments above session.entropy_file:
In OpenBSD however, there is no need for this, as the arc4random functions are available as a fast random source, generating high quality pseudo-random number streams.
This eliminates the usage of a file descriptor on these systems.
The idea herein is to extend the comments with an extra line: