fixes bug#71504 (php5.6 version of php7.0 bug#71317) #1751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat newentry != NULL
ext/phar/tests/tar/bug71504.phpt
Outdated
Contributor
There was a problem hiding this comment.
this files/folder should be cleaned up afterwards?
Contributor
Author
There was a problem hiding this comment.
True, however extracting the files is not needed to prove the memory leak so I removed the extraction of files from the test.
…cted instead of the first file, in line the behaviour of tar for amended files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reflected in bug report #71504 tar files with duplicate filenames cause a memoryleak, silently ignoring subsequent entry contrary to the behavour of tar which silently overwrite previous entries.
This pr mitigates the memory leak in the same way as pr #1748 does for php 7.0