Fix GH-15968: Avoid converting objects to strings in operator calculations.#16021
Merged
SakiTakamachi merged 2 commits intophp:masterfrom Sep 24, 2024
Merged
Fix GH-15968: Avoid converting objects to strings in operator calculations.#16021SakiTakamachi merged 2 commits intophp:masterfrom
SakiTakamachi merged 2 commits intophp:masterfrom
Conversation
Member
Author
|
Thanks! I plan to include this in RC1. At least it's better than leaving it as it is now. |
Member
|
Well, in coercive typing mode I would expect a class implementing |
Member
Author
|
hmm... For now, I will adopt this PR, but it might be worth considering making a "bug fix" in the next version or later, including the GMP issue. edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15968
As Gina commented, there was a problem with the function I was using.
#15968 (comment)
There are almost no cases where want to treat a stringable class other than the Number class as a string in operator calculations, so modify it so that the object is not converted to a string.